Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split browser tests into categories #5249

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Split browser tests into categories #5249

merged 1 commit into from
Jun 19, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 14, 2020 •
edited
Loading

Resolves brave/brave-browser#9204

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Apr 14, 2020
@NejcZdovc NejcZdovc changed the title Moves current tests in new folder Split browser tests into categories Jun 9, 2020
@NejcZdovc NejcZdovc force-pushed the browser-tests-split branch 5 times, most recently from 96fd0aa to 8282a46 Compare June 15, 2020 13:39
@NejcZdovc NejcZdovc force-pushed the browser-tests-split branch 2 times, most recently from b360325 to dd2684e Compare June 17, 2020 15:14
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 17, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows labels Jun 17, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review June 17, 2020 21:01
@NejcZdovc NejcZdovc force-pushed the browser-tests-split branch 2 times, most recently from 6c4bf4e to 467092c Compare June 18, 2020 07:54
@NejcZdovc NejcZdovc requested review from a team, emerick and zenparsing and removed request for a team June 18, 2020 07:54
emerick
emerick approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a few comments

components/brave_rewards/browser/test/common/rewards_browsertest_contribution.cc Outdated Show resolved Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_contribution.h Outdated Show resolved Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_contribution.h Outdated Show resolved Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_contribution.h Outdated Show resolved Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_network_util.cc Outdated Show resolved Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_network_util.cc Outdated Show resolved Hide resolved
@NejcZdovc NejcZdovc merged commit 67add5d into master Jun 19, 2020
@NejcZdovc NejcZdovc deleted the browser-tests-split branch June 19, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.

Split rewards browser tests in separate categories
2 participants
@NejcZdovc @emerick